Update Edit Footer for Cards#4752
Merged
Merged
Conversation
balloob
reviewed
Feb 5, 2020
balloob
approved these changes
Feb 6, 2020
balloob
reviewed
Feb 6, 2020
| ha-card { | ||
| border-top-right-radius: 0; | ||
| border-top-left-radius: 0; | ||
| box-shadow: rgba(0, 0, 0, 0.14) 0px 2px 2px 0px, |
Member
There was a problem hiding this comment.
is this still needed ? Isn't this built into the card ?
Contributor
Author
There was a problem hiding this comment.
This is a different shadow from the Ha-card. It shifts the shadow down so there is no shadow on the overlapping section
Member
|
ok to merge when last comment answered |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Updates the Style of the Edit Options to better flow with the current Card. This fixes the Material Design issues as there is not Shadow footer
Type of change
Additional information
⬇️
(old image with out HA-CARD) ❗️
(New Image with HA-CARD) ❗️
Checklist