Sensor card update to copy fill feature#4745
Conversation
|
|
| history.forEach((item, i) => getCoords(item, i, 0, detail)); | ||
| for (let i = 0; i < history.length; i += 1) { | ||
| getCoords(history[i], i, 0, detail); | ||
| } |
There was a problem hiding this comment.
This is for when there isn't enough history to fill the hours requested. The previous method would start the line in the middle of the card if there were only 12 hours of data when 24 were requested
There was a problem hiding this comment.
Might be me, but I don't see a difference in what it does, just a more difficult way to write the same ;-)
There was a problem hiding this comment.
The difference using the previous method. For loop starts at 0 and loops through no matter if the item is []. For Each ignores NULL/Undefined/[] items
There was a problem hiding this comment.
Therefore i starts at ex. 14. Meaning the first X value is 14 * xRatio
|
Please don't force push after reviews have started, it prevents us from spotting the changes. |
|
🎉 🐬 🎉 🐬 🎉 🐬 |
4 participants
Proposed change
This PR updates the Core Sensor card to mimic the fill feature of the Custom Graph Card
Type of change
Example configuration
Additional information
PR also moves the icon to the right side. Updates some CSS and CSS classes
Checklist
If user exposed functionality or configuration variables are added/changed: