Skip to content

✨ Add buttons row#4714

Merged
bramkragten merged 4 commits into
home-assistant:devfrom
iantrich:button-row
Feb 19, 2020
Merged

✨ Add buttons row#4714
bramkragten merged 4 commits into
home-assistant:devfrom
iantrich:button-row

Conversation

@iantrich
Copy link
Copy Markdown
Member

@iantrich iantrich commented Feb 1, 2020 •
edited
Loading

Breaking change

Proposed change

Add buttons row for entities card

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

type: entities
entities:
  - type: buttons
    entities:
      - light.bed_light
      - entity: light.kitchen_lights
        icon: 'mdi:lightbulb-group'

Additional information

image
top is the header buttons. middle is the buttons row.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@iantrich iantrich requested a review from bramkragten February 1, 2020 04:17
@iantrich iantrich self-assigned this Feb 1, 2020
@iantrich iantrich requested a review from balloob February 1, 2020 04:17
balloob
balloob reviewed Feb 1, 2020
View reviewed changes
Comment thread src/panels/lovelace/components/hui-buttons-base.ts Outdated
balloob
balloob reviewed Feb 1, 2020
View reviewed changes
Comment thread src/panels/lovelace/components/hui-buttons-base.ts
balloob
balloob reviewed Feb 1, 2020
View reviewed changes
Comment thread src/panels/lovelace/special-rows/hui-buttons-row.ts
balloob
balloob reviewed Feb 1, 2020
View reviewed changes
Comment thread src/panels/lovelace/header-footer/hui-buttons-header-footer.ts Outdated
bramkragten
bramkragten reviewed Feb 17, 2020
View reviewed changes
Comment thread src/panels/lovelace/create-element/create-row-element.ts Outdated
@bramkragten bramkragten merged commit 7046cba into home-assistant:dev Feb 19, 2020
@bramkragten bramkragten mentioned this pull request Feb 19, 2020
Merged
@lock lock Bot locked and limited conversation to collaborators Feb 21, 2020
@iantrich iantrich deleted the button-row branch April 1, 2020 02:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@balloob balloob balloob left review comments

@bramkragten bramkragten bramkragten approved these changes

Assignees

@iantrich iantrich

Labels

cla-signed Documentation Needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iantrich @balloob @bramkragten @homeassistant