Fixes add-on audio selector#4648
Merged
Merged
Conversation
bramkragten
reviewed
Jan 29, 2020
|
|
||
| private _setInputDevice(ev): void { | ||
| const device = ev.detail.device; | ||
| const device = ev.detail.item.attributes.device.value; |
Member
There was a problem hiding this comment.
set device as property and use ev.detail.item.device or use ev.detail.item.getAttribute("device")
Member
Author
There was a problem hiding this comment.
Property looked cleaner.
Member
There was a problem hiding this comment.
Yeah but now your attr-for-selected is missing
balloob
approved these changes
Feb 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
iron-selectinstead ofselected-item-changedto trigger_set*DeviceType of change
Example configuration
For the most part yaml is not really needed here is it?Additional information
Checklist
How? Why? Examples, please.
If user exposed functionality or configuration variables are added/changed: