Skip to content

Corrects add-on link#4634

Merged
balloob merged 5 commits into
home-assistant:devfrom
ludeeus:addonlink
Jan 28, 2020
Merged

Corrects add-on link#4634
balloob merged 5 commits into
home-assistant:devfrom
ludeeus:addonlink

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Jan 28, 2020

Proposed change

Fixes addon link ⛓

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

For the most part yaml is not really needed here is it?

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.

How? Why? Examples, please.

  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Jan 28, 2020

Why this changed so much is beyond me, some pre-commit hook going haywire 🤷‍♂

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 28, 2020

Prettier doing a new style formatting it seems. We should make sure that pre-commit and our CI/yarn use the same.

@balloob balloob merged commit 6e624b3 into home-assistant:dev Jan 28, 2020
${this.addon.description}.<br />
Visit
<a href=${this.addon.url} target="_blank">
<a href="${this.addon.url}" target="_blank">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary because it's dynamic.

@bramkragten bramkragten mentioned this pull request Jan 29, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Links to add-ons are broken

3 participants