Skip to content

Fix menu button for touch #4589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 2 commits into from
Jan 24, 2020
Merged

Fix menu button for touch #4589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
934cc6c
Fix menu button for touch
bramkragten Jan 24, 2020
39bb755
Missed 2
bramkragten Jan 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/panels/config/automation/action/ha-automation-action-row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ export default class HaAutomationActionRow extends LitElement {
></paper-icon-button>
<paper-listbox slot="dropdown-content">
<paper-item
@click=${this._switchYamlMode}
@tap=${this._switchYamlMode}
.disabled=${selected === -1}
>
${yamlMode
Expand All @@ -136,7 +136,7 @@ export default class HaAutomationActionRow extends LitElement {
"ui.panel.config.automation.editor.actions.duplicate"
)}
</paper-item>
<paper-item @click=${this._onDelete}>
<paper-item @tap=${this._onDelete}>
${this.hass.localize(
"ui.panel.config.automation.editor.actions.delete"
)}
Expand Down
4 changes: 2 additions & 2 deletions src/panels/config/automation/condition/ha-automation-condition-row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ export default class HaAutomationConditionRow extends LitElement {
slot="dropdown-trigger"
></paper-icon-button>
<paper-listbox slot="dropdown-content">
<paper-item @click=${this._switchYamlMode}>
<paper-item @tap=${this._switchYamlMode}>
${this._yamlMode
? this.hass.localize(
"ui.panel.config.automation.editor.edit_ui"
Expand All @@ -85,7 +85,7 @@ export default class HaAutomationConditionRow extends LitElement {
"ui.panel.config.automation.editor.conditions.duplicate"
)}
</paper-item>
<paper-item @click=${this._onDelete}>
<paper-item @tap=${this._onDelete}>
${this.hass.localize(
"ui.panel.config.automation.editor.conditions.delete"
)}
Expand Down
4 changes: 2 additions & 2 deletions src/panels/config/automation/trigger/ha-automation-trigger-row.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ export default class HaAutomationTriggerRow extends LitElement {
></paper-icon-button>
<paper-listbox slot="dropdown-content">
<paper-item
@click=${this._switchYamlMode}
@tap=${this._switchYamlMode}
.disabled=${selected === -1}
>
${yamlMode
Expand All @@ -118,7 +118,7 @@ export default class HaAutomationTriggerRow extends LitElement {
"ui.panel.config.automation.editor.triggers.duplicate"
)}
</paper-item>
<paper-item @click=${this._onDelete}>
<paper-item @tap=${this._onDelete}>
${this.hass.localize(
"ui.panel.config.automation.editor.triggers.delete"
)}
Expand Down
4 changes: 2 additions & 2 deletions src/panels/config/entities/ha-config-entities.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,7 @@ export class HaConfigEntities extends SubscribeMixin(LitElement) {
slot="dropdown-trigger"
></paper-icon-button>
<paper-listbox slot="dropdown-content">
<paper-icon-item @click="${this._showDisabledChanged}">
<paper-icon-item @tap="${this._showDisabledChanged}">
<paper-checkbox
.checked=${this._showDisabled}
slot="item-icon"
Expand All @@ -351,7 +351,7 @@ export class HaConfigEntities extends SubscribeMixin(LitElement) {
"ui.panel.config.entities.picker.filter.show_disabled"
)}
</paper-icon-item>
<paper-icon-item @click="${this._showRestoredChanged}">
<paper-icon-item @tap="${this._showRestoredChanged}">
<paper-checkbox
.checked=${this._showUnavailable}
slot="item-icon"
Expand Down
2 changes: 1 addition & 1 deletion src/panels/config/integrations/ha-config-entries-dashboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export class HaConfigManagerDashboard extends LitElement {
role="listbox"
selected="{{selectedItem}}"
>
<paper-item @click=${this._toggleShowIgnored}>
<paper-item @tap=${this._toggleShowIgnored}>
${this.hass.localize(
this._showIgnored
? "ui.panel.config.integrations.ignore.hide_ignored"
Expand Down
5 changes: 3 additions & 2 deletions src/panels/lovelace/components/hui-card-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ export class HuiCardOptions extends LitElement {
horizontal-align="right"
vertical-align="bottom"
vertical-offset="40"
close-on-activate
>
<paper-icon-button
icon="hass:dots-vertical"
Expand All @@ -71,12 +72,12 @@ export class HuiCardOptions extends LitElement {
)}
></paper-icon-button>
<paper-listbox slot="dropdown-content">
<paper-item @click="${this._moveCard}">
<paper-item @tap="${this._moveCard}">
${this.hass!.localize(
"ui.panel.lovelace.editor.edit_card.move"
)}</paper-item
>
<paper-item .class="delete-item" @click="${this._deleteCard}">
<paper-item .class="delete-item" @tap="${this._deleteCard}">
${this.hass!.localize(
"ui.panel.lovelace.editor.edit_card.delete"
)}</paper-item
Expand Down