Skip to content

Update issue and PR templates#4553

Merged
balloob merged 2 commits into
devfrom
frenck-2020-0114
Jan 22, 2020
Merged

Update issue and PR templates#4553
balloob merged 2 commits into
devfrom
frenck-2020-0114

Conversation

@frenck
Copy link
Copy Markdown
Member

@frenck frenck commented Jan 21, 2020

This PR proposes new PR & issue templates.

Goals:

  • Provide cleaner templates, with less Markdown, making it easier to read in the issue editor (less ** wrapping and inline links)
  • Guide users when opening up an issue (shows a selection in GitHub, cross repo), redirecting people to the right places.
  • Adds a PR template.
  • Improvements to the inline comments.
  • Provide more streamlined templates across our org.


- [ ] The code change is tested and works locally.
- [ ] There is no commented out code in this PR.
- [ ] Tests have been added to verify that the new code works.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought I made it a checkbox, it would be interesting, right? 👍

Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing.

@balloob balloob merged commit def0c51 into dev Jan 22, 2020
@delete-merged-branch delete-merged-branch Bot deleted the frenck-2020-0114 branch January 22, 2020 17:33
@lock lock Bot locked and limited conversation to collaborators Jan 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants