🐛 fix confirmation dialog actions#4497
Closed
iantrich wants to merge 1 commit into
Closed
Conversation
bramkragten
reviewed
Jan 17, 2020
| </paper-dialog-scrollable> | ||
| <div class="paper-dialog-buttons"> | ||
| <mwc-button @click="${this._dismiss}"> | ||
| <mwc-button @action=${this._dismiss}> |
Member
There was a problem hiding this comment.
It doesn't have the action handler, so it doesn't get the action event?
Member
|
I would rather just find the problem, might look at it myself today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4468
I was able to replicate the issue but could not figure out why
@clickwas not functioning properly. We have plenty of other uses of@clickthat work on iOS, so not sure what makes this different. The action-handler feels like a work-around, I guess, but it has been annoying me quite a bit on mobile as well.