Add group binding to the ZHA config panel and misc. cleanup#4466

Merged

bramkragten merged 19 commits into

home-assistant:devfrom

dmulcahey:dm/zha-group-binding-2

Jan 17, 2020

Contributor

dmulcahey commented Jan 13, 2020

This PR:

adds group binding to the ZHA config panel
cleans up items mentioned in the last PR
fixes group selection logic with multi-select
tweaks css for consistency in alignment

dmulcahey requested a review from bramkragten

January 13, 2020 13:26

homeassistant added the cla-signed label

dmulcahey force-pushed the dm/zha-group-binding-2 branch from a6fa7ce to a575257 Compare

January 14, 2020 12:31

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-clusters-data-table.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-clusters-data-table.ts

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-clusters-data-table.ts

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-device-card.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-device-card.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-device-card.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-device-card.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-group-binding.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-group-binding.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/config/zha/zha-groups-data-table.ts Outdated

bramkragten approved these changes

View reviewed changes

dmulcahey added 16 commits

January 16, 2020 07:06


          clean up zha device card and usage

23b1f11


          group binding tile


          add cluster selection to group binding tile

1ced19a


          fix css class name

f934626


          fix filtering

01d2302


          multiselect for clusters in group binding

1472f4b


          pass narrow to cluster table

b81f358


          fix tables

ade91ca


          fix device page

aabe7c4


          address remaing comments from previous PR

fc10de3


          fix bad cherry-pick

041af47


          css cleanup

6ab21e0


          consistency

3e315b0


          use properties

1794fd4


          translations

e9ab10d


          add confirmation dialog to remove button

68df117

dmulcahey force-pushed the dm/zha-group-binding-2 branch from a575257 to 68df117 Compare

January 16, 2020 12:06

dmulcahey added 3 commits

January 16, 2020 08:15


          fix css

1c0e273


          review comments

714fc66


          remove noise

424dd71

Contributor Author

dmulcahey commented Jan 17, 2020

@bramkragten addressed comments and added a question in response to one of yours. I think this is good to merge. LMK if you agree.

bramkragten merged commit a2a039e into home-assistant:dev

lock Bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels