Virtualize logbook#4450
Merged
Merged
Conversation
balloob
reviewed
Jan 12, 2020
ludeeus
reviewed
Jan 12, 2020
| } | ||
|
|
||
| protected render(): TemplateResult | void { | ||
| if (!this.entries.length) { |
Member
There was a problem hiding this comment.
if (!this.entries?.length) {
Don't forget 😃
This was needed on my system at least
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By virtualizing the logbook the initial rendering is way faster.
Where on large amounts of entries the rendering could take > 30 seconds it is now instant.
Fixes #3762
Before: https://cdn.discordapp.com/attachments/505438107290566656/664841842671484929/old-logbook.mp4
After: https://cdn.discordapp.com/attachments/505438107290566656/664841888439730176/new-logbook.mp4