Skip to content

Add multi select to entity registry#4424

Merged
bramkragten merged 5 commits into
devfrom
entity_reg
Jan 7, 2020
Merged

Add multi select to entity registry#4424
bramkragten merged 5 commits into
devfrom
entity_reg

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Jan 6, 2020

image
image
image

@iantrich
Copy link
Copy Markdown
Member

iantrich commented Jan 6, 2020

cool

Comment thread src/components/data-table/ha-data-table.ts Outdated
Comment thread src/panels/config/entity_registry/ha-config-entity-registry.ts Outdated
Comment thread src/panels/config/entity_registry/ha-config-entity-registry.ts Outdated
Comment thread src/panels/config/entity_registry/ha-config-entity-registry.ts Outdated
Comment thread src/panels/config/entity_registry/ha-config-entity-registry.ts Outdated
Copy link
Copy Markdown
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 🎉 Few minor comments, ok to merge after that.

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 6, 2020

Can the status column be centrally aligned ?

Comment thread src/panels/config/entity_registry/ha-config-entity-registry.ts Outdated
@bramkragten
Copy link
Copy Markdown
Member Author

Can the status column be centrally aligned ?

It already is
image

@balloob
Copy link
Copy Markdown
Member

balloob commented Jan 6, 2020

Perfect. Initial screenshot looked off
image

@bramkragten
Copy link
Copy Markdown
Member Author

It's the header that is not in the centre..

@bramkragten bramkragten merged commit f02fa6a into dev Jan 7, 2020
@delete-merged-branch delete-merged-branch Bot deleted the entity_reg branch January 7, 2020 11:29
@bramkragten bramkragten mentioned this pull request Jan 7, 2020
@lock lock Bot locked and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants