Force rerender on update/save#4396
Merged
Merged
Conversation
bramkragten
reviewed
Jan 2, 2020
| window.onbeforeunload = null; | ||
| } | ||
| if (this._changed) { | ||
| this.requestUpdate(); |
Member
There was a problem hiding this comment.
Why do we need the requestUpdate?
Member
Author
There was a problem hiding this comment.
When I tested this, that was the best I could come up with, that is now a few days ago, I can probably do something different now to handle it, I'll have a look after work.
Member
There was a problem hiding this comment.
_changed is a property, so if that is updated it should re-render?
Member
Author
There was a problem hiding this comment.
Should, yes.
does, not so much 🤷♂ (can be tested here https://demo.home-assistant.io/#/lovelace/0)
I can probably find a better way later today.
Member
Author
There was a problem hiding this comment.
Found a better way, looking at styles now
Member
|
I think the disabled button needs a little styling, the text is very hard to read now. |
Member
Author
bramkragten
approved these changes
Jan 2, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changes
@property().Closes #4391
This also fixes an issue where the "Saved" and "Unsaved changes" were not showing.