Split up mdi icons#4379
Merged
bramkragten merged 13 commits intodevfrom May 5, 2020
Merged
Conversation
balloob
reviewed
Dec 26, 2019
balloob
reviewed
Dec 26, 2019
balloob
reviewed
Dec 26, 2019
balloob
reviewed
Dec 26, 2019
balloob
reviewed
May 4, 2020
balloob
reviewed
May 4, 2020
balloob
reviewed
May 4, 2020
Merged
balloob
reviewed
May 5, 2020
| return curString.substring(0, i + 1); | ||
| } | ||
| } | ||
| console.error("Cannot find differentiator", curString, prevString); |
Member
There was a problem hiding this comment.
I don't think that it could happen, but we should probably raise here to make sure that it breaks.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do:
ha-icon(likepaper-icon-button)hass:icons with imports from@mdi/jsso they are code splitted (and look in to caching them when used inha-iconso when a user uses it they wont need to load a part?)mdiicons