Skip to content

Add support to add all device entities to Lovelace#4356

Merged
bramkragten merged 8 commits into
devfrom
add-device-to-lovelace
Dec 23, 2019
Merged

Add support to add all device entities to Lovelace#4356
bramkragten merged 8 commits into
devfrom
add-device-to-lovelace

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Dec 17, 2019

If someone has a good idea where to place the button, please let me know :-)
image

Updated location:
image

Works the same as unused entities, except now with all entities of a device.

@SeanPM5
Copy link
Copy Markdown
Contributor

SeanPM5 commented Dec 17, 2019

Awesome feature!

I think the button might make a tiny bit more sense below the list of device entities. Current placement is asking the user to perform an action before they've even read the list of entities. They'd need to scroll down to read them and then back up to push the button.

Not a huge deal, but I think it feels a little more natural to have button beneath the list. Then by the time you read the list of entities you've already made an informed decision and can simply press the button if you want it.

Comment thread src/panels/config/devices/ha-config-device-page.ts Outdated
Comment thread src/panels/config/devices/ha-config-device-page.ts Outdated
Comment thread src/panels/config/devices/ha-config-device-page.ts Outdated
Comment thread src/panels/lovelace/ha-panel-lovelace.ts Outdated
@balloob
Copy link
Copy Markdown
Member

balloob commented Dec 18, 2019

Add it as an action to the card that lists the entities ? (So below like Sean suggested). Although addnig it as a link below the description on the left wouldn't be a bad idea either.

@bramkragten
Copy link
Copy Markdown
Member Author

Did it as a card action :-)

Comment thread src/panels/config/devices/device-detail/ha-device-entities-card.ts Outdated
Comment thread src/panels/config/devices/device-detail/ha-device-entities-card.ts Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants