Add support to add all device entities to Lovelace#4356
Merged
Conversation
Contributor
|
Awesome feature! I think the button might make a tiny bit more sense below the list of device entities. Current placement is asking the user to perform an action before they've even read the list of entities. They'd need to scroll down to read them and then back up to push the button. Not a huge deal, but I think it feels a little more natural to have button beneath the list. Then by the time you read the list of entities you've already made an informed decision and can simply press the button if you want it. |
iantrich
reviewed
Dec 17, 2019
iantrich
reviewed
Dec 17, 2019
iantrich
reviewed
Dec 17, 2019
iantrich
reviewed
Dec 17, 2019
Member
|
Add it as an action to the card that lists the entities ? (So below like Sean suggested). Although addnig it as a link below the description on the left wouldn't be a bad idea either. |
Member
Author
|
Did it as a card action :-) |
balloob
reviewed
Dec 19, 2019
balloob
reviewed
Dec 19, 2019
balloob
approved these changes
Dec 20, 2019
This was referenced Jan 7, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If someone has a good idea where to place the button, please let me know :-)

Updated location:

Works the same as unused entities, except now with all entities of a device.