Add group management to the ZHA config panel#4352
Closed
dmulcahey wants to merge 30 commits into
Closed
Conversation
Member
|
It would help reviewing if it would be in smaller blocks, so that would be great. Make sure the separate blocks are functional without the others, so we can merge (and maybe release) them one by one. |
Contributor
Author
|
Cool. Does the plan outlined at the bottom of the post make sense? If so, I’ll try to do that tonight. I’m also gonna leave this open to aid myself while splitting this up. |
Member
|
I think so, I'm not really familiar enough with how groups work for zigbee. |
Contributor
Author
|
First PR opened supporting only viewing of existing groups: #4365 |
This was referenced Dec 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a UI for managing ZHA Zigbee groups. It supports the basic CRUD actions. I'll split this into separate PR's if it is preferred. Here are some screen shots that outline the functionality:
Manage groups added to main ZHA config panel:

Groups View:

Selected Groups details:


Create Group view:

Device details dialog in group view:

I wanted to get this open to gather feedback as I have had this in this state for a few weeks now. I am thinking about how to break this up if that's preferred. I am thinking I could open the following PR's:
Let me know if that makes sense to do or not.