Skip to content

Add group management to the ZHA config panel#4352

Closed
dmulcahey wants to merge 30 commits into
home-assistant:devfrom
dmulcahey:dm/zha-groups
Closed

Add group management to the ZHA config panel#4352
dmulcahey wants to merge 30 commits into
home-assistant:devfrom
dmulcahey:dm/zha-groups

Conversation

@dmulcahey
Copy link
Copy Markdown
Contributor

@dmulcahey dmulcahey commented Dec 16, 2019

This PR adds a UI for managing ZHA Zigbee groups. It supports the basic CRUD actions. I'll split this into separate PR's if it is preferred. Here are some screen shots that outline the functionality:

Manage groups added to main ZHA config panel:
Screen Shot 2019-12-16 at 11 12 55 AM

Groups View:
Screen Shot 2019-12-16 at 11 13 09 AM

Selected Groups details:
Screen Shot 2019-12-16 at 11 13 51 AM
Screen Shot 2019-12-16 at 11 14 03 AM

Create Group view:
Screen Shot 2019-12-16 at 11 14 42 AM

Device details dialog in group view:
Screen Shot 2019-12-16 at 11 15 10 AM

I wanted to get this open to gather feedback as I have had this in this state for a few weeks now. I am thinking about how to break this up if that's preferred. I am thinking I could open the following PR's:

  • add the manage groups button to the main screen and the groups view
  • add the individual groups details view
  • add editing of individual group (including delete)
  • add group creation

Let me know if that makes sense to do or not.

@bramkragten
Copy link
Copy Markdown
Member

It would help reviewing if it would be in smaller blocks, so that would be great. Make sure the separate blocks are functional without the others, so we can merge (and maybe release) them one by one.

@dmulcahey
Copy link
Copy Markdown
Contributor Author

dmulcahey commented Dec 17, 2019

Cool. Does the plan outlined at the bottom of the post make sense? If so, I’ll try to do that tonight.

I’m also gonna leave this open to aid myself while splitting this up.

@bramkragten
Copy link
Copy Markdown
Member

I think so, I'm not really familiar enough with how groups work for zigbee.

@dmulcahey
Copy link
Copy Markdown
Contributor Author

First PR opened supporting only viewing of existing groups: #4365

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants