Convert script and automation editor to lit#4327
Merged
Merged
Conversation
balloob
reviewed
Dec 9, 2019
| ].filter(Boolean), | ||
| resolve: { | ||
| extensions: [".ts", ".js", ".json", ".tsx"], | ||
| extensions: [".ts", ".js", ".json"], |
Member
There was a problem hiding this comment.
Epic 🎉
Guess we might need to add it back once we start working with the calendar ?
balloob
reviewed
Dec 9, 2019
| @@ -14457,4 +14457,4 @@ zip-stream@^1.2.0: | |||
| archiver-utils "^1.3.0" | |||
Member
There was a problem hiding this comment.
Can't we also drop preact and preact-compat from package.json and webpack.js ?
Member
Author
There was a problem hiding this comment.
Yeah, wanted to do that in a followup because preact is now used as react for the calendar.
balloob
approved these changes
Dec 9, 2019
delete-merged-branch
Bot
deleted the
convert-script-and-automation-editor-to-lit
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.