Convert automation conditions to Lit#4321
Merged
Merged
Conversation
balloob
reviewed
Dec 5, 2019
balloob
reviewed
Dec 5, 2019
balloob
reviewed
Dec 5, 2019
balloob
reviewed
Dec 5, 2019
balloob
reviewed
Dec 5, 2019
| @property() public condition!: SunCondition; | ||
|
|
||
| public static get defaultConfig() { | ||
| return {}; |
Member
There was a problem hiding this comment.
Shouldn't this include sunrise / sunset ?
Member
Author
There was a problem hiding this comment.
No, you can't remove them when set, and since you could only set before and not set after or otherwise, a default doesn't make sense?
balloob
approved these changes
Dec 5, 2019
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Few small comments. Looks great !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.