Skip to content

Fix set-temperature controls in climate more-info for falsy temperatures#4300

Merged
bramkragten merged 1 commit intodevfrom
fix-falsy-temperatures
Dec 2, 2019
Merged

Fix set-temperature controls in climate more-info for falsy temperatures#4300
bramkragten merged 1 commit intodevfrom
fix-falsy-temperatures

Conversation

@thomasloven
Copy link
Copy Markdown
Contributor

@thomasloven thomasloven commented Dec 1, 2019

Fix #4296 (I assume. I haven't tested it because none of my climate devices go to 0 degrees...)

@bramkragten bramkragten merged commit e7e9e2c into dev Dec 2, 2019
@delete-merged-branch delete-merged-branch Bot deleted the fix-falsy-temperatures branch December 2, 2019 08:23
@bramkragten bramkragten mentioned this pull request Dec 4, 2019
@oandrew
Copy link
Copy Markdown

oandrew commented Dec 16, 2019

I suspect this broke the UI for thermostats that can dynamically switch between one or two setpoints.

For instance, when thermostat is in single setpoint mode in has attributes:

temperature: 67
target_temp_high: null
target_temp_low: null

stateObj.attributes.target_temp_low !== undefined evalutes to true and makes all temperature controls visible.

I think it should be stateObj.attributes.target_temp_low != null instead.
Tricky javascript :)

@bramkragten
Copy link
Copy Markdown
Member

Please create an issue for this, but it should probably check for both null and undefined

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Target temperature in climate entity info window hides at value of zero

4 participants