Fix set-temperature controls in climate more-info for falsy temperatures#4300
Merged
bramkragten merged 1 commit intodevfrom Dec 2, 2019
Merged
Fix set-temperature controls in climate more-info for falsy temperatures#4300bramkragten merged 1 commit intodevfrom
bramkragten merged 1 commit intodevfrom
Conversation
bramkragten
approved these changes
Dec 2, 2019
Merged
|
I suspect this broke the UI for thermostats that can dynamically switch between one or two setpoints. For instance, when thermostat is in single setpoint mode in has attributes:
I think it should be |
Member
|
Please create an issue for this, but it should probably check for both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #4296 (I assume. I haven't tested it because none of my climate devices go to 0 degrees...)