Area/multiple devices and name support for thingtalk automations#4272
Merged
bramkragten merged 5 commits intodevfrom Dec 2, 2019
Merged
Area/multiple devices and name support for thingtalk automations#4272bramkragten merged 5 commits intodevfrom
bramkragten merged 5 commits intodevfrom
Conversation
balloob
reviewed
Nov 28, 2019
| this.excludeDomains, | ||
| this.includeDeviceClasses | ||
| ); | ||
| if (!this._areaPicker || areas.length === 0) { |
Member
There was a problem hiding this comment.
Isn't this weird? Shouldn't this be taken care of by whoever renders this component ?
Member
Author
There was a problem hiding this comment.
You want to split the area and device picker in the parent? The parent should also know if there are areas that meet the requirements then...
Member
There was a problem hiding this comment.
hmmmmmm okay let's stick with this.
balloob
reviewed
Nov 28, 2019
balloob
reviewed
Nov 28, 2019
Member
|
This is wild and amazing. |
bramkragten
changed the title
balloob
approved these changes
Nov 30, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.