Skip to content

Adds "air" at the bottom of the page#4267

Merged
bramkragten merged 3 commits intohome-assistant:devfrom
ludeeus:config-dashboard-air
Nov 25, 2019
Merged

Adds "air" at the bottom of the page#4267
bramkragten merged 3 commits intohome-assistant:devfrom
ludeeus:config-dashboard-air

Conversation

@ludeeus
Copy link
Copy Markdown
Member

@ludeeus ludeeus commented Nov 22, 2019

Fixes #4263
image

@bramkragten
Copy link
Copy Markdown
Member

bramkragten commented Nov 23, 2019

Won't this add a margin to both the elements? When we only want to target the last one?

Comment thread src/panels/config/dashboard/ha-config-dashboard.ts Outdated
@bramkragten
Copy link
Copy Markdown
Member

And check if the promo banner also needs some "air"

Co-Authored-By: Bram Kragten <mail@bramkragten.nl>
@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Nov 23, 2019

Won't this add a margin to both the elements?

Make sense, but it did not look off, :last-child are probably better

@ludeeus
Copy link
Copy Markdown
Member Author

ludeeus commented Nov 23, 2019

Added to promo too:
image
vs
image

@bramkragten bramkragten merged commit f6afc92 into home-assistant:dev Nov 25, 2019
@ludeeus ludeeus deleted the config-dashboard-air branch November 25, 2019 18:16
@bramkragten bramkragten mentioned this pull request Dec 4, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration menu not properly finished in advanced mode

3 participants