Conversation
| ? html` | ||
| <round-slider | ||
| min="1" | ||
| min="0" |
There was a problem hiding this comment.
This changes the function of the slider.
Now sliding to the bottom will turn the light off as opposed to setting it to minimum brightness.
This results in the handle disappearing, which might be confusing.
There was a problem hiding this comment.
This fixes the handle disappearing, but yeah it does turn the light off when sliding all the way down. I think I prefer it this way. Do we have more options? Old behaviour was not turning off but still showing the handle?
There was a problem hiding this comment.
Min was 1 with the old slider too. https://github.com/home-assistant/home-assistant-polymer/pull/3634/files#diff-f2231026bfc2c43209404df9b7bbb679L35
It's probably better this way. I just didn't want it to slide by without comment.
There was a problem hiding this comment.
But in the old version the handle did stay, is that something that was changed in round-slider?
There was a problem hiding this comment.
Probably. The slider is disabled if the value is outside of the range.
Maybe the old one drew it outside the bar, or just clamped it to the min-max range?
There was a problem hiding this comment.
I'm not a fan of slider turning off the light. Getting to 1% brightness is going to take skill now
There was a problem hiding this comment.
I suggest to make this change now, so we have the handle back when the light is off, and check if we can get the old behaviour of round slider back.
| position: absolute; | ||
| width: 70%; | ||
| height: 70%; | ||
| max-height: calc(100% - 40px); |
There was a problem hiding this comment.
Does this work with icons of different aspect ratios?
There was a problem hiding this comment.
Icons are always square
|
I'm not sure how it behaved before, but does the height of the card change between lights that support vs. don't support brightness? Edit: #4256 shows how it behaved before... whatever it does now is better. |
Mmm yeah, it now looks like an entity button card when it doesn't support brightness...
|
* Fix light card * Remove unused class * Fix for when entity is not available * Fix active state
|
Are there any plans to bring back the look of pre 102 which renders all light cards the same size, even if they have dimming capabilities? Now it look quite ugly if one mixes Dimmable and non-dimmable lights in a horizontal stack.
|
|
Please open an Issue and refer to this PR instead. |
5 participants
Fixes #4251
Fixes #4256