Skip to content

Add secondary-info: last-triggered#4222

Merged
bramkragten merged 5 commits intohome-assistant:devfrom
Mariusthvdb:patch-1
Nov 23, 2019
Merged

Add secondary-info: last-triggered#4222
bramkragten merged 5 commits intohome-assistant:devfrom
Mariusthvdb:patch-1

Conversation

@Mariusthvdb
Copy link
Copy Markdown
Contributor

@Mariusthvdb Mariusthvdb commented Nov 14, 2019

add last-triggered to the currently available options 'entity-id' and 'last-changed' see:https://www.home-assistant.io/lovelace/entities/#secondary_info

Docs: home-assistant/home-assistant.io#11221

add last-triggered to the currently available options 'entity-id' and 'last-changed' see:https://www.home-assistant.io/lovelace/entities/#secondary_info
Comment thread src/panels/lovelace/components/hui-generic-entity-row.ts
Comment thread src/panels/lovelace/components/hui-generic-entity-row.ts Outdated
@Mariusthvdb
Copy link
Copy Markdown
Contributor Author

so Travis build fails. Now what would this need me to do:

ERROR: src/panels/lovelace/components/hui-generic-entity-row.ts:108:67 - Insert `⏎···············`

?

@Mariusthvdb
Copy link
Copy Markdown
Contributor Author

hope this suffices now @bramkragten? Do you have any other remarks?
thanks!

@Mariusthvdb
Copy link
Copy Markdown
Contributor Author

so what would I need to do next?

@bramkragten
Copy link
Copy Markdown
Member

Wait a little and write some documentation :-)

@Mariusthvdb
Copy link
Copy Markdown
Contributor Author

Mariusthvdb commented Nov 18, 2019

ok cool, I'll wait ;-)

what documentation would you need? for the https://www.home-assistant.io/lovelace/entities/#secondary_info line? Dont think I can edit that yet, if this Pr hasn't been merged yet? Or should I write it here, like:

secondary_info
(string)(Optional)
Show additional info. Values: entity-id, last-changed, last-triggered (only for automations and script).

@bramkragten
Copy link
Copy Markdown
Member

You should create a PR for https://github.com/home-assistant/home-assistant.io and link to this PR.

@Mariusthvdb
Copy link
Copy Markdown
Contributor Author

thanks, and trying to, but creating a Pr there leads me to:

Schermafbeelding 2019-11-18 om 09 59 28

I cant find the place to link this pr Mariusthvdb:patch-1 (is that even the name I need to link to) and can't find the actual page I need to change : https://www.home-assistant.io/lovelace/entities/#secondary_info

again, sorry for my noob-ness, but as is abundantly clear, I need some further guidance...

@bramkragten
Copy link
Copy Markdown
Member

In the top right of every page of home-assistant.io is a button edit this page click that and you will to the right page in the repo.

Edit that, create a PR and like to this PR, that would be https://github.com/home-assistant/home-assistant-polymer/pull/4222

@Mariusthvdb
Copy link
Copy Markdown
Contributor Author

thanks Bram, consider it done.

@Mariusthvdb
Copy link
Copy Markdown
Contributor Author

thanks @klaasnicolaas for correcting the documentation. back to @bramkragten for approving this PR ;-)
can't wait...

@bramkragten bramkragten merged commit 8158846 into home-assistant:dev Nov 23, 2019
@Mariusthvdb Mariusthvdb deleted the patch-1 branch November 23, 2019 23:49
frenck pushed a commit to home-assistant/home-assistant.io that referenced this pull request Nov 26, 2019
adding info to the docs following PR home-assistant/frontend#4222 which add last-triggered to the secondary_info options
@bramkragten bramkragten mentioned this pull request Dec 4, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants