Change to thermostat card to reflect step_temp on set-temperature#4221
Merged
bramkragten merged 5 commits intohome-assistant:devfrom Nov 25, 2019
bannhead:step_temp_coherence
Merged
Change to thermostat card to reflect step_temp on set-temperature#4221bramkragten merged 5 commits intohome-assistant:devfrom bannhead:step_temp_coherence
bramkragten merged 5 commits intohome-assistant:devfrom
bannhead:step_temp_coherence
Conversation
bannhead
changed the title
2 tasks
|
I don't think that is is a good idea to show a decimal for current temperature when it is equal to 0 just for sake of "consistency". Even if thermostat cannot be set using a decimal, e.g. 0.5°C, it doesn't mean that not displaying it in the current temperature is correct. |
Contributor
Author
|
My code only impacts set temperature. The thermostat card shows the current temperature step in whole if F and in halves if C, but gives priority to "precision" parameter if supplied by the thermostat. My only change is to reflect the "target_temperature_step" -used by the slider- to "set temperature". |
thomasloven
force-pushed
the
new-round-slider
branch
from
2cc4284 to
ed016b6
Compare
Member
|
Please rebase this PR |
Member
|
Your PR targets the branch |
bramkragten
approved these changes
Nov 25, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference #4219
This is my proposal to change the graphic aspect of the set temperature when the thermostat works with whole temperature steps.