Conversation
balloob
reviewed
Nov 10, 2019
| */ | ||
| const re_key_reference = /\[%key:([^%]+)%\]/; | ||
| function lokalise_transform(data, original) { | ||
| function lokaliseTransform(data, original, file) { |
Member
There was a problem hiding this comment.
We so much need to re-do this file in a non-stream way so we can actually see what's going on .
Merged
|
Hi! I migrated this morning to 0.102.0. Issue is still there. What happened? |
Member
Author
|
That's not easy to say when there is so little information. But if you think there (still) is a bug, please create an issue with information instead of responding on a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4181