Skip to content

Improvements for customize config panel#415

Merged
balloob merged 2 commits into
home-assistant:masterfrom
andrey-git:c4
Aug 29, 2017
Merged

Improvements for customize config panel#415
balloob merged 2 commits into
home-assistant:masterfrom
andrey-git:c4

Conversation

@andrey-git
Copy link
Copy Markdown
Contributor

Improvements for customize config panel:

  • Don't save empty json values.
  • Allow per-domain attributes.
  • Allow '*' - all-domains array lists.
  • Prevent reassignment of LOGIC_STATE_ATTRIBUTES as script tag can be loaded more than once.

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Oops! Something went wrong! :(
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

Copy link
Copy Markdown

@houndci-bot houndci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Oops! Something went wrong! :(
ESLint couldn't find the plugin "eslint-plugin-html". This can happen for a couple different reasons:
1. If ESLint is installed globally, then make sure eslint-plugin-html is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
    npm i eslint-plugin-html@latest --save-dev
If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.

@balloob balloob merged commit 5bdbc49 into home-assistant:master Aug 29, 2017
@andrey-git andrey-git deleted the c4 branch August 29, 2017 19:19
tkdrob pushed a commit to tkdrob/frontend that referenced this pull request Apr 20, 2021
* Map template example

* Add beta flag

* Review comments
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants