action-handler#4115

Merged

iantrich merged 11 commits into

home-assistant:devfrom

iantrich:action-handler

Nov 1, 2019

Member

iantrich commented Oct 23, 2019 •

edited

Loading

Single action event that includes a action type
hasHold option to determine if ripple should be displayed or not
if no hold_action defined, a hold will trigger the tap_action

iantrich added the wip label

iantrich requested a review from bramkragten

October 23, 2019 18:08

iantrich self-assigned this

homeassistant added the cla-signed label

Member

bramkragten commented Oct 23, 2019

Fire the tap action, as that would also happen on a normal click.

bramkragten reviewed

View reviewed changes

src/panels/lovelace/cards/hui-entity-button-card.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/lovelace/common/directives/action-handler-directive.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/lovelace/cards/hui-entity-button-card.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/lovelace/cards/hui-entity-button-card.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/lovelace/common/directives/action-handler-directive.ts Outdated

Member Author

iantrich commented Oct 24, 2019

cc @thomasloven this is going to break card-tools https://github.com/thomasloven/lovelace-card-tools/blob/master/card-tools.js#L224

Contributor

thomasloven commented Oct 24, 2019

Thanks for the heads up!

iantrich removed the wip label

iantrich requested a review from bramkragten

October 24, 2019 16:10

Member Author

iantrich commented Oct 28, 2019 •

edited

Loading

@balloob I brought those haptic changes over to this PR as we discussed the other day in chat.

https://github.com/home-assistant/home-assistant-polymer/pull/4115/files#diff-da1e15d6ddae66047990a3f8c4370c81R86

Member

bramkragten commented Oct 29, 2019

Please rebase, needed it in 0.101: #4152

bramkragten reviewed

View reviewed changes

src/data/lovelace.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/lovelace/badges/hui-state-label-badge.ts Outdated

balloob reviewed

View reviewed changes

src/panels/lovelace/common/handle-action.ts Outdated

iantrich force-pushed the action-handler branch from 62af4fb to b824d91 Compare

October 29, 2019 19:44

bramkragten reviewed

View reviewed changes

src/panels/lovelace/common/directives/action-handler-directive.ts Outdated

iantrich mentioned this pull request

♿ Add tabindex to lovelace elements #4160

Merged

bramkragten reviewed

View reviewed changes

src/panels/lovelace/common/directives/action-handler-directive.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/lovelace/common/handle-action.ts Outdated

bramkragten reviewed

View reviewed changes

src/panels/lovelace/common/handle-action.ts Outdated

bramkragten approved these changes

View reviewed changes

Member

bramkragten left a comment

OK to merge after final comments are addressed

iantrich added 4 commits

November 1, 2019 12:42


          action-handler

4cca613


          comments

556858c


          address comments

4c2a09b


          finish conversion

72e2ff1

iantrich added 7 commits

November 1, 2019 12:42


          move haptics

597eec4


          address comments

1f024a4


          lint

ee4c07a


          keyup

2681c30


          double enter

5dc3841


          address comments

e02395c


          keyup

1abd4b7

iantrich force-pushed the action-handler branch from 75a5c75 to 1abd4b7 Compare

November 1, 2019 17:43

iantrich merged commit 274c201 into home-assistant:dev

iantrich deleted the action-handler branch

November 1, 2019 18:15

bramkragten mentioned this pull request

20191108.0 #4193

Merged

github-actions Bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels