Skip to content

Add French Netatmo thermostat states#4111

Closed
Twanislas wants to merge 1 commit into
home-assistant:devfrom
Twanislas:netatmo-translations
Closed

Add French Netatmo thermostat states#4111
Twanislas wants to merge 1 commit into
home-assistant:devfrom
Twanislas:netatmo-translations

Conversation

@Twanislas
Copy link
Copy Markdown
Contributor

@Twanislas Twanislas commented Oct 23, 2019

Hi !

These are showing in English, here's the french version :)

image
image

Cheers from Belgium !

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @Twanislas,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@bramkragten
Copy link
Copy Markdown
Member

Hi @Twanislas thanks for this, but we do our translation management in Lokalise. Please see https://developers.home-assistant.io/docs/en/internationalization_translation.html

@Twanislas
Copy link
Copy Markdown
Contributor Author

Oh !

Sorry for the spam then, I'll head over there ;)

Thanks !

@Twanislas Twanislas deleted the netatmo-translations branch October 23, 2019 17:44
@bramkragten
Copy link
Copy Markdown
Member

No problem!

@Twanislas
Copy link
Copy Markdown
Contributor Author

Sorry for the noise again but I fail to understand how to add new keys for translation in Lokalise.
Should those be added first somewhere and it will reflect in Lokalise to be available for transalation ?

Thanks !

@bramkragten
Copy link
Copy Markdown
Member

Yes, you can't add new keys in Lokalise, that should be done in /src/translations/en.json that will be uploaded to Lokalise when we push to master.

@Twanislas
Copy link
Copy Markdown
Contributor Author

Gotcha ! Thanks again !

Opened #4128 ;)

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants