Make updateHass not async#4060
Merged
Merged
Conversation
Member
Author
|
I remember again why it is async. By making it async, it will be executed after the current code block. So if a single code block makes two changes, |
bramkragten
approved these changes
Oct 19, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So there is no comment here on why
_updateHassis async. I tried going through the GitHub blame but couldn't find it. So I decided to remove it and it all works fine, so that's good.If we merge this, let's keep an eye on issues that could be related. Generally I think that this should be better as now you could use
this.hassright after updating Hass and it should represent the latest, and greatest, state.