Skip to content

Translated developer tools template page#4050

Merged
bramkragten merged 1 commit into
home-assistant:devfrom
springstan:translateTemplatePage
Oct 18, 2019
Merged

Translated developer tools template page#4050
bramkragten merged 1 commit into
home-assistant:devfrom
springstan:translateTemplatePage

Conversation

@springstan
Copy link
Copy Markdown
Member

Issue affected: #3429

Description:

  • added developer tools template page translations to src/translations/en.json
  • updated developer-tools-template.js accordingly

Result:
grafik

@springstan
Copy link
Copy Markdown
Member Author

I was not sure whether or not to translate the code in the template editor.
Would that be a good idea? Since jinja itself is more or less plain English.

@bramkragten
Copy link
Copy Markdown
Member

Let's not do that for now, will go wrong in translating probably many times.

Copy link
Copy Markdown
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks! 🦁

@springstan
Copy link
Copy Markdown
Member Author

Yeah that was also something I was considering, it is probably better to leave it like that, at least for now.

@bramkragten bramkragten merged commit 4421711 into home-assistant:dev Oct 18, 2019
@bramkragten bramkragten mentioned this pull request Oct 23, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants