Update snapshot actions to be a list#4045
Merged
bramkragten merged 2 commits intoOct 19, 2019
Merged
Conversation
Member
|
I think the text of the delete action should be the same color as the icon |
Contributor
Author
|
Good point @bramkragten . I updated the text to also be the warning red color. I initially tried to target it with |
Member
|
You could put the warning class on the |
Contributor
Author
|
Yeah I tried that. The text and icon are both the blue color in that instance. |
f21e5c1 to
eb4712e
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #4007
I moved the delete button to the bottom to match the mocks, moved labels to the buttons. I also removed the margin on
paper-dialog-scrollablebecause it left a gap between the section name and the radio buttons compared to the other sections. I added a section name (Actions) at the bottom as the buttons looked a bit weird now that they were a list.Before

After
