Skip to content

added title to view configuation #4037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 6 commits into from
Oct 22, 2019
Merged

added title to view configuation #4037

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
dbddc36
added title to view configuation
drakeloud Oct 17, 2019
3e76c5d
replacing let with const
drakeloud Oct 17, 2019
2c28bd8
added localization change
drakeloud Oct 21, 2019
5504abc
updated view config title
drakeloud Oct 21, 2019
f42f888
linter updates
drakeloud Oct 21, 2019
56cacb8
Prettier updates
drakeloud Oct 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/panels/lovelace/editor/view-editor/hui-edit-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,16 @@ export class HuiEditView extends LitElement {
return this.shadowRoot!.querySelector("ha-paper-dialog")!;
}

private get _viewConfigTitle(): string {
if (!this._config || !this._config.title || this._config.title === "") {

@bramkragten bramkragten Oct 21, 2019 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is no config we might want to change the header to Add new view?

@bramkragten bramkragten Oct 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An empty string is falsy in javascript so this._config.title === "" is not needed.

Suggested change
if (!this._config || !this._config.title || this._config.title === "") {
if (!this._config || !this._config.title) {

return this.hass!.localize(
"ui.panel.lovelace.editor.edit_view.header"
);;
}

return this.hass!.localize("ui.panel.lovelace.editor.edit_view.header_name", this._config.title)

@bramkragten bramkragten Oct 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the key header_name exist? You have to add it to src/translations/en.json: Edit view {name}
And you have to pass the name of the placeholder you want to replace:

Suggested change
return this.hass!.localize("ui.panel.lovelace.editor.edit_view.header_name", this._config.title)
return this.hass!.localize("ui.panel.lovelace.editor.edit_view.header_name", name, this._config.title)

}

protected render(): TemplateResult | void {
let content;
switch (this._curTab) {
Expand Down Expand Up @@ -118,7 +128,7 @@ export class HuiEditView extends LitElement {
return html`
<ha-paper-dialog with-backdrop>
<h2>
${this.hass!.localize("ui.panel.lovelace.editor.edit_view.header")}
${this._viewConfigTitle}
</h2>
<paper-tabs
scrollable
Expand Down