Skip to content

add sensor card to first demo#4035

Merged
iantrich merged 2 commits into
home-assistant:devfrom
iantrich:demo-sensor
Oct 22, 2019
Merged

add sensor card to first demo#4035
iantrich merged 2 commits into
home-assistant:devfrom
iantrich:demo-sensor

Conversation

@iantrich
Copy link
Copy Markdown
Member

@iantrich iantrich commented Oct 17, 2019

image

part of #3319

@bramkragten
Copy link
Copy Markdown
Member

bramkragten commented Oct 17, 2019

Let's give it a nicer title, US Dollar to Indian Rupee Rate? Or should we just do a temp sensor? Seems more common and speaks more to a new user?

@iantrich
Copy link
Copy Markdown
Member Author

iantrich commented Oct 17, 2019

The temps weren't working on the demo for the sensor card. No measurement, I think. Didn't want to look into it 😄

@iantrich iantrich self-assigned this Oct 17, 2019
bramkragten
bramkragten approved these changes Oct 22, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@bramkragten bramkragten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🦁

@iantrich
Copy link
Copy Markdown
Member Author

iantrich commented Oct 22, 2019

Thanks! 🦁

you are very welcome

@iantrich iantrich merged commit 49d0f23 into home-assistant:dev Oct 22, 2019
@iantrich iantrich deleted the demo-sensor branch October 22, 2019 19:43
@bramkragten bramkragten mentioned this pull request Oct 23, 2019
Merged
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bramkragten bramkragten bramkragten approved these changes

Assignees

@iantrich iantrich

Labels

cla-signed hacktoberfest

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iantrich @bramkragten @homeassistant