Split data table background color into separate theme variable#4031
Merged
Conversation
iantrich
reviewed
Oct 17, 2019
| --ha-paper-slider-pin-font-size: 15px; | ||
|
|
||
| /* set data table style */ | ||
| --mdc-data-table-background-color: var(--card-background-color); |
Member
There was a problem hiding this comment.
Suggested change
| --mdc-data-table-background-color: var(--card-background-color); | |
| --data-table-background-color: var(--card-background-color); |
iantrich
reviewed
Oct 17, 2019
|
|
||
| .mdc-data-table { | ||
| background-color: var(--card-background-color); | ||
| background-color: var(--mdc-data-table-background-color); |
Member
There was a problem hiding this comment.
Suggested change
| background-color: var(--mdc-data-table-background-color); | |
| background-color: var(--data-table-background-color); |
Member
|
I don't like that we currently expose paper themes and don't want to get into the habit of exposing it for other proprietary elements. We should be more generic and clear. |
Contributor
Author
|
Alright, should be good now. |
bramkragten
approved these changes
Oct 21, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow greater theme customization and will match the way colors are set up for other components.