Skip to content

Improvements for zwave group config#398

Merged
balloob merged 3 commits into
home-assistant:masterfrom
andrey-git:zwave
Aug 26, 2017
Merged

Improvements for zwave group config#398
balloob merged 3 commits into
home-assistant:masterfrom
andrey-git:zwave

Conversation

@andrey-git
Copy link
Copy Markdown
Contributor

@andrey-git andrey-git commented Aug 18, 2017

Improvements for zwave group config

  • Show group-selector first
  • Show info about the group, including node names and instance numbers - without requiring to select target node.
  • Only show 'remove' button if target node is in the list.

Missing features:

  • Allow adding / removing instances to the group.
  • Show instance label instead of just instance number.

@balloob
Copy link
Copy Markdown
Member

balloob commented Aug 18, 2017

Do you think that we should migrate this config editor to use the <ha-config-section> component like the rest of the config panel uses?

@andrey-git
Copy link
Copy Markdown
Contributor Author

I have applied ha-config-section for zwave.

@andrey-git
Copy link
Copy Markdown
Contributor Author

Kind ping :)

@balloob
Copy link
Copy Markdown
Member

balloob commented Aug 26, 2017

Sorry, missed this one :(

@balloob balloob merged commit b211894 into home-assistant:master Aug 26, 2017
@bramkragten bramkragten mentioned this pull request Feb 19, 2020
tkdrob pushed a commit to tkdrob/frontend that referenced this pull request Apr 20, 2021
…istant#398)

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tom Brien <tom@byth.co.uk>
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants