Add width property to light card to fix #3964#3972
Merged
Conversation
Member
|
I suggest to use: bottom: 16px;
box-sizing: border-box;
text-align: center;
width: 100%;
padding: 0 16px; |
Member
|
And remove: left: 50%;
transform: translate(-50%); |
Contributor
Author
|
@bramkragten -- Works for me in DevTools, will push the change here shortly. |
bramkragten
reviewed
Oct 10, 2019
| @@ -213,9 +213,12 @@ export class HuiLightCard extends LitElement implements LovelaceCard { | |||
| .name { | |||
| position: absolute; | |||
| top: 160px; | |||
Member
There was a problem hiding this comment.
This should be deleted as we now have a bottom instead of a top
bramkragten
reviewed
Oct 18, 2019
| @@ -213,9 +213,12 @@ export class HuiLightCard extends LitElement implements LovelaceCard { | |||
| .name { | |||
| position: absolute; | |||
| top: 160px; | |||
Member
There was a problem hiding this comment.
Suggested change
| top: 160px; |
Contributor
Author
|
Updated. Sorry, missed the last comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a width property to the CSS for a light card's name/title box. Without a width set, it is wrapping the text on long names too soon with plenty of room to spare in the card.
This is to fix issue #3964.