Skip to content

filter system users from Person editor #3958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iantrich merged 4 commits into from
Oct 16, 2019
Merged

filter system users from Person editor #3958

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dbaad0f
filter system users from Person editor
iantrich Oct 8, 2019
3e487b3
address review comments
iantrich Oct 9, 2019
9d50ec5
address comments
iantrich Oct 15, 2019
46f4290
address comments
iantrich Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/components/user/ha-user-picker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,23 @@ import { fireEvent } from "../../common/dom/fire_event";
import { User, fetchUsers } from "../../data/user";
import { compare } from "../../common/string/compare";

class HaEntityPicker extends LitElement {
class HaUserPicker extends LitElement {
public hass?: HomeAssistant;
@property() public label?: string;
@property() public value?: string;
@property() public users?: User[];

private _sortedUsers = memoizeOne((users?: User[]) => {
if (!users || users.length === 1) {
return users || [];
if (!users) {
return [];
}
const sorted = [...users];

const filteredUsers = users!.filter((user) => !user.system_generated);

if (filteredUsers.length === 1) {
return filteredUsers;
}
const sorted = [...filteredUsers];
Comment thread
iantrich marked this conversation as resolved.
Outdated
sorted.sort((a, b) => compare(a.name, b.name));
return sorted;
});
Expand Down Expand Up @@ -101,4 +107,4 @@ class HaEntityPicker extends LitElement {
}
}

customElements.define("ha-user-picker", HaEntityPicker);
customElements.define("ha-user-picker", HaUserPicker);