Feature/badge preview#3902
Conversation
|
Don't think will play nicely with custom badges #3867 |
No, with custom badges comes a new editor. We should take the badges out of the view editor and give it it's own edit dialog per badge just like cards. |
|
Ok, It´s not so clear to me, what the next steps for this PR are. It reads, that it does not make a lot of sense to merge this changes in because it will be obsolete once the new editor is in place, correct? I could revert the preview mode in entity editor but keep the refactoring for the |
|
I think we should wait for the custom badges PR to merge, we can then refactor this PR so it uses the new logic to build the badges. Would be a relative simple change I think. |
|
I'll try to get the custom badges PR cleaned up in the next couple of days |
|
Custom badges where merged, mainly this logic is changed: Maybe @iantrich can help you get this PR updated? |
|
Hey. I've updated my branch to the recent changes without any conflicts. So the badge preview still works. |
|
Only yaml right now, next step is to create a editor for badges. |
|
Is there than anything more to do for this PR? The preview seems to work correctly with the new badge build logic. |
|
Yes, we need to add the new create badge logic. We only create |
|
Closing this as it has gone stale. If you would like to continue on this please open a new PR. |
Fixes #3825
This PR adds a preview for the View Configuration to getter a better visual feedback how the badges would look like.