Default hide disabled entities from entity registry#3863
Merged
Conversation
balloob
reviewed
Oct 2, 2019
| ></paper-item | ||
| > | ||
| ${this._entities.map((entry) => { | ||
| if (!this._showDisabled && entry.disabled_by) { |
Member
There was a problem hiding this comment.
Instead of doing this inside the map, should we use .filter and potentially store that inside a memoize?
balloob
approved these changes
Oct 2, 2019
bramkragten
force-pushed
the
hide-disabled
branch
from
bf52294 to
0679afe
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.