Skip to content

Allow yaml in dev events #3861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 2 commits into from
Oct 2, 2019
+5 −3
Merged

Allow yaml in dev events #3861

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
730da76
Allow yaml in dev events
bramkragten Oct 2, 2019
19bc700
remove json
bramkragten Oct 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/panels/developer-tools/event/developer-tools-event.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import "@polymer/paper-input/paper-textarea";
import { html } from "@polymer/polymer/lib/utils/html-tag";
import { PolymerElement } from "@polymer/polymer/polymer-element";

import yaml from "js-yaml";

import "../../../resources/ha-style";
import "./events-list";
import "./event-subscribe-card";
Expand Down Expand Up @@ -61,7 +63,7 @@ class HaPanelDevEvent extends EventsMixin(PolymerElement) {
value="{{eventType}}"
></paper-input>
<paper-textarea
label="Event Data (JSON, optional)"
label="Event Data (YAML, optional)"
value="{{eventData}}"
></paper-textarea>
<mwc-button on-click="fireEvent" raised>Fire Event</mwc-button>
Expand Down Expand Up @@ -106,10 +108,10 @@ class HaPanelDevEvent extends EventsMixin(PolymerElement) {
var eventData;

try {
eventData = this.eventData ? JSON.parse(this.eventData) : {};
eventData = this.eventData ? yaml.safeLoad(this.eventData) : {};
} catch (err) {
/* eslint-disable no-alert */
alert("Error parsing JSON: " + err);
alert("Error parsing YAML: " + err);
/* eslint-enable no-alert */
return;
}
Expand Down