Guard for null badges#3841
Merged
Merged
Conversation
balloob
reviewed
Oct 1, 2019
| cards: this._cards, | ||
| badges: this._badges!.map((entityConf) => entityConf.entity), | ||
| ...this._config, | ||
| badges: this._badges!.map((entityConf) => entityConf.entity), |
Member
There was a problem hiding this comment.
By adding it below the ...this._config, it will override whatever is in config. Is this on purpose ?
Member
Author
There was a problem hiding this comment.
Yeah, the config is the view config with the cards and badges stripped off, so we don't have any duplicates to worry about, just want to keep the order of the yaml somewhat the same.
balloob
reviewed
Oct 1, 2019
| this._config = viewConfig; | ||
| this._badges = badges ? processEditorEntities(badges) : []; | ||
| this._badges = badges | ||
| ? processEditorEntities(badges.filter(Boolean)) |
Member
There was a problem hiding this comment.
Instead of adding guards everywhere, can't we filter it when Lovelace config is loaded ?
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3838