Skip to content

Fix firefox overflow #3806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 3 commits into from
Sep 25, 2019
Merged

Fix firefox overflow #3806

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f180e76
Fix firefox overflow
bramkragten Sep 25, 2019
3e15449
Add comment
bramkragten Sep 25, 2019
5240d48
Align
bramkragten Sep 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 16 additions & 8 deletions src/panels/lovelace/hui-root.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,18 +354,26 @@ class HUIRoot extends LitElement {
#view {
min-height: calc(100vh - 112px);
/**
* Since we only set min-height, if child nodes need percentage
* heights they must use absolute positioning so we need relative
* positioning here.
*
* https://www.w3.org/TR/CSS2/visudet.html#the-height-property
*/
* Since we only set min-height, if child nodes need percentage
* heights they must use absolute positioning so we need relative
* positioning here.
*
* https://www.w3.org/TR/CSS2/visudet.html#the-height-property
*/
position: relative;
display: flex;
}
#view > * {
flex: 1;
width: 100%;
/**
* The view could get larger than the window in Firefox
* to prevent that we set the max-width to 100%
* flex-grow: 1 and flex-basis: 100% should make sure the view
* stays full width.
*
* https://github.com/home-assistant/home-assistant-polymer/pull/3806
*/
flex: 1 1 100%;
max-width: 100%;
Copy link
Copy Markdown
Member

@balloob balloob Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the page look with 1 column? Since the background is on this element, not having it be 100% will mess with the width ?

Copy link
Copy Markdown
Member Author

@bramkragten bramkragten Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base width is still 100%, it would be the same as:

          flex: 1;
          width: 100%;
          max-width: 100%;

Copy link
Copy Markdown
Member Author

@bramkragten bramkragten Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but the flex-grow: 1 would also make it 100% width, so it should not be necessary at all

Copy link
Copy Markdown
Member

@balloob balloob Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see.

Copy link
Copy Markdown
Member

@balloob balloob Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS hell. Sometimes it's easier to just remove all rules and built it up again. Oh well.

We should start adding comments to CSS rules like this to make sure we know why they are there.

}
#view.tabs-hidden {
min-height: calc(100vh - 64px);
Expand Down