Skip to content

Add hassio supervisor and os update notice#3798

Merged
bramkragten merged 6 commits into
devfrom
hassio-update
Sep 26, 2019
Merged

Add hassio supervisor and os update notice#3798
bramkragten merged 6 commits into
devfrom
hassio-update

Conversation

@bramkragten
Copy link
Copy Markdown
Member

@bramkragten bramkragten commented Sep 23, 2019

Adds a similar card as when there is a ha update for hassio and hassos.

@bramkragten bramkragten changed the title WIP Add hassio supervisor and os update notice Add hassio supervisor and os update notice Sep 24, 2019
@bramkragten bramkragten requested a review from balloob September 24, 2019 18:47
Comment thread hassio/src/dashboard/hassio-update.ts Outdated

@customElement("hassio-update")
export class HassioUpdate extends LitElement {
@property() public hass?: HomeAssistant;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can start using hass! pretty much everywhere, it's always there :)

Suggested change
@property() public hass?: HomeAssistant;
@property() public hass!: HomeAssistant;

Comment thread hassio/src/hassio-main.ts Outdated
]);
this._supervisorInfo = supervisorInfo;
this._hostInfo = hostInfo;
this._hassOsInfo = hassOsInfo;
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's only needed in the updater card, maybe we should just fetch that data there ?

@bramkragten bramkragten merged commit 05a258c into dev Sep 26, 2019
@delete-merged-branch delete-merged-branch Bot deleted the hassio-update branch September 26, 2019 11:47
@bramkragten bramkragten mentioned this pull request Oct 2, 2019
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants