Conversation
balloob
reviewed
Sep 23, 2019
| ? { noEmit: false } | ||
| : { | ||
| target: "es5", | ||
| checkJs: false, |
balloob
approved these changes
Sep 23, 2019
Member
balloob
left a comment
balloob
left a comment
There was a problem hiding this comment.
Going ahead and merging it. Will test a build locally and push hotfix.
Member
Author
|
hassio is throwing a bunch of TS errors |
balloob
pushed a commit
that referenced
this pull request
Sep 23, 2019
* Bring back babel for ES5 builds * Remove ts from babel
|
Is this only in dev? |
Member
Author
|
No, this is for our production builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3781
Fixes #3722