Skip to content

Green shade in climate history for platforms that don't support hvac_action #3787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bramkragten merged 3 commits into from
Sep 24, 2019
Merged

Green shade in climate history for platforms that don't support hvac_action #3787

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5f28ee2
Green shade in climate history for platforms that don't support HVAC_…
OnFreund Sep 22, 2019
db4b07e
The presence of hvac_action can change over time
OnFreund Sep 24, 2019
665b41e
Move static condition out of anon function
OnFreund Sep 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/components/state-history-chart-line.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,14 +155,14 @@ class StateHistoryChartLine extends LocalizeMixin(PolymerElement) {
domain === "climate" ||
domain === "water_heater"
) {
const isHeating =
domain === "climate"
? (state) => state.attributes.hvac_action === "heating"
: (state) => state.state === "heat";
const isCooling =
domain === "climate"
? (state) => state.attributes.hvac_action === "cooling"
: (state) => state.state === "cool";
const isHeating = (state) =>

@balloob balloob Sep 23, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now we're no longer consistent but could change on a per-state basis. I think that we should go through all the states and see if any has an hvac action. We should calculate similarly to how we calculate hasTargetRange

@OnFreund OnFreund Sep 24, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know the presence of hvac_action can change over time, but the code now supports it. It's only accounted for within the given timeframe, but I think that's as good as it gets, unless the platform has some way of signaling that hvac_action might be present.

domain === "climate" && state.attributes.hvac_action
? state.attributes.hvac_action === "heating"
: state.state === "heat";
const isCooling = (state) =>
domain === "climate" && state.attributes.hvac_action
? state.attributes.hvac_action === "cooling"
: state.state === "cool";

// We differentiate between thermostats that have a target temperature
// range versus ones that have just a target temperature
Expand Down