climate: display humidity if the device does not support temperature#3743
Closed
Shulyaka wants to merge 1 commit into
Closed
climate: display humidity if the device does not support temperature#3743Shulyaka wants to merge 1 commit into
Shulyaka wants to merge 1 commit into
Conversation
Signed-off-by: Denis Shulyaka <Shulyaka@gmail.com>
Member
|
Can we remove the card changes for now? I'm right in the middle of a conversion for this card: #3734 |
Contributor
Author
|
No problem, I will rebase my PR when you merge #3734 |
Member
|
You now assume that if a device doesn't have |
Contributor
Author
|
Apparently, HA developers want humidifiers to be a separate integration home-assistant/architecture#288 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a
climatedevice only supports humidity control but no temperature, the frontend shows grayed-out slider with disabled controlls and an empty graph on the detailed view. It does allow to control humidity though with the detailed view, but it would be much more informative if we displayed current humidity on the main card when the device does not support temperature.This pull request adds the described functionality.