Skip to content

Add padding when large class is added#3729

Closed
Misiu wants to merge 1 commit into
home-assistant:devfrom
Misiu:patch-1
Closed

Add padding when large class is added#3729
Misiu wants to merge 1 commit into
home-assistant:devfrom
Misiu:patch-1

Conversation

@Misiu
Copy link
Copy Markdown
Contributor

@Misiu Misiu commented Sep 16, 2019

Fixes #3711

@homeassistant
Copy link
Copy Markdown
Contributor

Hi @Misiu,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@Misiu
Copy link
Copy Markdown
Contributor Author

Misiu commented Sep 16, 2019

Test entry:

type: vertical-stack
cards:
  - cards:
      - type: thermostat
        entity: climate.upstairs
      - type: thermostat
        entity: climate.upstairs
    type: horizontal-stack
  - cards:
      - type: thermostat
        entity: climate.upstairs
      - type: thermostat
        entity: climate.upstairs
    type: horizontal-stack

Before:
ha_before
After:
ha_after

@bramkragten
Copy link
Copy Markdown
Member

This also means the modes will be a lot closer to the current mode and the set temperature will drop down. In your specific use case this turns out better, but not in every situation.

Before:
image

After:
image

@Misiu
Copy link
Copy Markdown
Contributor Author

Misiu commented Sep 17, 2019

@bramkragten I agree, I tested this only with my case. What entry did You use? Can You post it here?
I can give this a second look, but I need a week or two to finish my current project (HA related).
Maybe there should be 3 types of size? small, normal and large? this way by default I can align everything in normal state and add modifiers to small and large views.

@bramkragten
Copy link
Copy Markdown
Member

We are working on replacing the round slider, let's wait for that and see if this is still a thing.
#3734

@Misiu
Copy link
Copy Markdown
Contributor Author

Misiu commented Sep 17, 2019

@bramkragten sure :) In a future project I'm planning to use 16 thermostats so I want to squish 4 in a single card to save space.
Before I start anything I'd like to have the UI fixed for such a scenario. Then the only thing that will remain is how the generic thermostat works - home-assistant/core#20154, hopefully, it will be fixed till then 🙂

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Thermostat card doesn't look good when it is small (unneeded padding)

3 participants