UI Editor for picture-glance card#3709
Merged
Merged
Conversation
bramkragten
reviewed
Sep 16, 2019
bramkragten
reviewed
Sep 16, 2019
bramkragten
reviewed
Sep 16, 2019
bramkragten
reviewed
Sep 16, 2019
bramkragten
reviewed
Sep 16, 2019
bramkragten
reviewed
Sep 16, 2019
Member
|
We should try to make our editors as clear as possible, it might be a good idea to add a little paragraph to explain what some options and functions do. |
Member
Author
|
I agree that our editors should be clear, but they are still a WIP. It could get pretty verbose trying to explain in detail everything that is going on here. For now I have just put in a link to the documentation. |
bramkragten
reviewed
Sep 20, 2019
bramkragten
reviewed
Sep 20, 2019
iantrich
force-pushed
the
picture-glance-editor
branch
from
1c63529 to
a9f002a
Compare
bramkragten
reviewed
Sep 25, 2019
| } | ||
|
|
||
| get _aspect_ratio(): string { | ||
| return this._config!.aspect_ratio || "50%"; |
Member
There was a problem hiding this comment.
Suggested change
| return this._config!.aspect_ratio || "50%"; | |
| return this._config!.aspect_ratio || ""; |
bramkragten
approved these changes
Sep 25, 2019
Member
bramkragten
left a comment
bramkragten
left a comment
There was a problem hiding this comment.
OK to merge after comment
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3700