Fix history showing extra points.#350
Merged
Merged
Conversation
|
@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @armills, @balloob and @turbokongen to be potential reviewers. |
balloob
reviewed
Jul 24, 2017
| prevValues = values; | ||
| } | ||
|
|
||
| if (domain === 'thermostat') { |
Member
There was a problem hiding this comment.
Why remove this? This means that for thermostats we are no longer plotting target and current temperatures
Member
There was a problem hiding this comment.
oh gosh, I see now that the code was duplicated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix history showing extra points.
History data used to duplicate the last point (sometimes beyond "now")
In addition both timeline and line added extra last point.
This PR removes the extra data point and fixes timeline and line not to log points after "now" (could be due to client-server time mismatch)