Merged
Conversation
Contributor
Author
|
This is an even better method of: #3136. I can add media_player here too i think. |
elupus
force-pushed
the
simplify_list_selection
branch
from
999a464 to
f94d8f7
Compare
elupus
force-pushed
the
simplify_list_selection
branch
from
f94d8f7 to
dcd9b99
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a simplification of listbox selected usage.
By using attr-for-selected and listening for the on-selected-changed property, the extra
property used for selected item can fully be dropped.
The first stage commits in this pull contain the same approach previously added by just avoiding the index usage. But i think the full change make more sense.