Skip to content

Fix a bad else statement #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
robbiet480 wants to merge 2 commits into from
Closed

Fix a bad else statement #3130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
939fb67
Fix a bad else statement
robbiet480 Apr 27, 2019
90ef425
Space
robbiet480 Apr 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/external_app/external_messaging.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export class ExternalMessaging {
}
if (window.externalApp) {
window.externalApp.externalBus(JSON.stringify(msg));
} else {
} else if (window.webkit) {
Copy link
Copy Markdown
Member

@balloob balloob Apr 27, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't fix it. The problem is I that externalBus is not defined because he uses an older iOS app. We should only set up the external bus if we detect that either externalApp.externalBus or webkit!.messageHandlers.externalBus exists inside ExternalAuth.

window.webkit!.messageHandlers.externalBus.postMessage(msg);
}
}
Expand Down